Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.directory_monitor): Improve internal stats #13089

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Apr 14, 2023

Required for all PRs

This to better distinguish between 2 directory_monitor instances and the files they processed/dropped.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 14, 2023
@Hipska
Copy link
Contributor Author

Hipska commented Apr 14, 2023

Please also check 6bedf62 if that would be accepted or if I need to rollback/change..

@Hipska Hipska changed the title feat(inputs.directory_monitor): Add directory tag to the internal stats feat(inputs.directory_monitor): Improve internal stats Apr 14, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this break existing queries as they now need to accumulate over all directories?

@Hipska
Copy link
Contributor Author

Hipska commented Apr 14, 2023

Hmm, correct. Do you suggest to have both metrics then (1 with and 1 without the directory tag)?

@srebhan
Copy link
Member

srebhan commented Apr 14, 2023

@Hipska yeah maybe add new metrics with a "per dir" suffix or similar...

@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think re-registering the metric would be a good way for backward compatibility...

@srebhan srebhan self-assigned this May 2, 2023
@Hipska Hipska requested a review from srebhan May 8, 2023 14:50
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @Hipska!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 15, 2023
@srebhan srebhan assigned powersj and unassigned srebhan May 15, 2023
@powersj powersj merged commit f0dc15f into influxdata:master May 17, 2023
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
@Hipska Hipska deleted the feat/input/directory_monitor/selfstat_tag branch September 26, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants