-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.directory_monitor): Improve internal stats #13089
feat(inputs.directory_monitor): Improve internal stats #13089
Conversation
… of files to process
Please also check 6bedf62 if that would be accepted or if I need to rollback/change.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this break existing queries as they now need to accumulate over all directories?
Hmm, correct. Do you suggest to have both metrics then (1 with and 1 without the directory tag)? |
@Hipska yeah maybe add new metrics with a "per dir" suffix or similar... |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think re-registering the metric would be a good way for backward compatibility...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @Hipska!
Required for all PRs
This to better distinguish between 2 directory_monitor instances and the files they processed/dropped.