Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.amqp_consumer): Avoid deprecations when handling defaults #12818

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Mar 9, 2023

resolves #12811

Improve the handling of defaults to avoid triggering deprecation warnings by not using URL.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 9, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 9, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - so the issue stems from not using the struct's Init and instead declaring values in the default init? We may need to check some other plugins with deprecated options as well.

@srebhan
Copy link
Member Author

srebhan commented Mar 9, 2023

Yeah true. More importantly, we set the deprecated URL in init, so I cleaned up the whole stuff a bit on the way...

@srebhan srebhan merged commit 501e920 into influxdata:master Mar 9, 2023
@srebhan srebhan deleted the amqp_consumer_issue_12811 branch March 9, 2023 14:59
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated warning when "brokers" used for inputs.amqp_consumer
2 participants