-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add sample-configuration for TLS client options #12728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall love having this so we keep things in sync! just one question about naming that was throwing me off while reviewing this.
After some more thoughts this approach has several drawbacks:
Given all those limitation (especially 1 and 2) I'm closing this PR as we need to come up with something more flexible. |
1 could be solved by not including it for those kind of plugins, but I agree to close and find a better solution. Maybe let sample.conf be a golang template where you include the tls.conf? |
@Hipska that would be one way. In any way we should generate a |
I don't see the need for that, why would that rendered sample.conf need to be checked in the repo? (It only needs to be rendered in the readme, but that is currently already the case.) In other words, why is N°2 a problem? |
I do like the tls client.conf sample, that should be added to the repo anyway. |
95da167
to
9c858ea
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Fine with me. |
Add a sample-configuration for the TLS client-config.