feat(inputs.internet_speed): server ID include and exclude filter #12617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to exclude or include specific speedtest server IDs. If a user excludes a server ID that server is always excluded from selection. If a user includes a specific server ID, then we will look for only that ID. This does not let a user pick a random server ID. The speedtest-go library will receive the 10 closet servers. As such, users need to be careful as they can prevent any server from being picked. fixes: influxdata#11449 fixes: influxdata#11625 fixes: influxdata#12595
telegraf-tiger
bot
added
feat
This was referenced Feb 3, 2023
Co-authored-by: Sven Rebhan <[email protected]>
Co-authored-by: Sven Rebhan <[email protected]>
Co-authored-by: Sven Rebhan <[email protected]>
Co-authored-by: Sven Rebhan <[email protected]>
|
@srebhan thanks for taking a look, comments resolved |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
added
the
ready for final review
|
Assign it back to you. Merge if you feel it's ready! |
Merged
3 tasks
|
@powersj Thank you for this! I know it's merged already some time ago. But I still want to thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to exclude or include specific speedtest server IDs. If a user excludes a server ID that server is always excluded from selection. If a user includes a specific server ID, we will look for only that ID.
This does not let a user pick a random server ID. The speedtest-go library will receive the 10 closet servers. As such, users need to be careful as they can prevent any server from being picked.
fixes: #11449
fixes: #11625
fixes: #12595