-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.dns_query): Add IP field(s) #12519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great as usual, only comment is on the naming of the new include field options
Thanks - you or I can merge once tests pass! |
Do you have an example of such a metric? |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
resolves #10452
This PR adds a new
include_fields
option which, if containing"IP"
or"all IPs"
, will allow to output the IP address or all IP addresses for the queried domain as field(s). Please note that the IPs are not ordered in any way but are output in the order they arrive in the DNS response.