Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.dns_query): Add IP field(s) #12519

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jan 18, 2023

resolves #10452

This PR adds a new include_fields option which, if containing "IP" or "all IPs", will allow to output the IP address or all IP addresses for the queried domain as field(s). Please note that the IPs are not ordered in any way but are output in the order they arrive in the DNS response.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 18, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 20, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great as usual, only comment is on the naming of the new include field options

plugins/inputs/dns_query/README.md Outdated Show resolved Hide resolved
@powersj
Copy link
Contributor

powersj commented Jan 20, 2023

Thanks - you or I can merge once tests pass!

@Hipska
Copy link
Contributor

Hipska commented Jan 20, 2023

Do you have an example of such a metric?

@srebhan srebhan merged commit 4102260 into influxdata:master Jan 20, 2023
@srebhan srebhan deleted the dns_query_issue_10452 branch January 20, 2023 15:40
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dns feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dns_query input plugin - Pull FQDN IPs when querying
3 participants