fix(processors): Correctly setup processors #12081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srebhan
added
regression
This was referenced Oct 21, 2022
powersj
approved these changes
Oct 21, 2022
powersj
approved these changes
Oct 21, 2022
|
Sorry, meant to leave a comment @srebhan need to resolve a quick conflict |
srebhan
force-pushed
the
issue-docker-647
branch
from
ec72d4c to
7dfd145
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
dba-leshop
pushed a commit
to dba-leshop/telegraf
that referenced
this pull request
Oct 30, 2022
popey
pushed a commit
that referenced
this pull request
Nov 2, 2022
(cherry picked from commit 87125f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #12080
resolves influxdata/influxdata-docker#647
This PR fixes a processor conversion fallout leading to potentially missing metrics when using processors in combination with aggregators, here especially the
dedupprocessor. The background is that PR #11600 changed the way processors are initialized. Before the mentioned PR new and independent instances of a processors were created to be run before and after an aggregator. #11600 then changes this to only create a single instance, shared between the processing steps (before and after the aggregator) leading to side-effects. This is especially noticeable in thededupprocessor as in the second processing step (after aggregation) the same instance sees the same metric twice and removes it while no metrics was emitted to the output in the first processing step (before the aggregator), leading to completely dropping all metrics.This PR now creates to independent instances of the processor for the two processing steps just as before #11600.