-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rename inputs.internet_speed.enable_file_download to match upstream intent #11877
Conversation
`memory_saving_mode` is a more appropriate name for this variable, as this is the upstream feature that is toggled. Also add a paragraph to the README to explain what this option does, and why it might be required. Fixes: #11870
Thanks so much for the pull request! |
!signed-cla |
This reverts commit e9442ed. `make check` passed locally with this change, but failed in CircleCI.
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for taking the time to put this together!
memory_saving_mode
is a more appropriate name for this variable, as this is the upstream feature that is toggled.Also add a paragraph to the README to explain what this option does, and why it might be required.
Required for all PRs
resolves #11870