Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename inputs.internet_speed.enable_file_download to match upstream intent #11877

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Conversation

g-a-c
Copy link
Contributor

@g-a-c g-a-c commented Sep 23, 2022

memory_saving_mode is a more appropriate name for this variable, as this is the upstream feature that is toggled.

Also add a paragraph to the README to explain what this option does, and why it might be required.

Required for all PRs

resolves #11870

`memory_saving_mode` is a more appropriate name for this variable, as this is the upstream feature that is toggled.

Also add a paragraph to the README to explain what this option does, and why it might be required.

Fixes: #11870
@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Sep 23, 2022
@g-a-c
Copy link
Contributor Author

g-a-c commented Sep 23, 2022

!signed-cla

This reverts commit e9442ed.

`make check` passed locally with this change, but failed in CircleCI.
@telegraf-tiger
Copy link
Contributor

@g-a-c g-a-c marked this pull request as ready for review September 23, 2022 23:15
Copy link
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. thanks!

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for taking the time to put this together!

@powersj powersj merged commit 2d124a4 into influxdata:master Sep 26, 2022
popey pushed a commit that referenced this pull request Oct 3, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.internet_speed.enable_file_download option appears to be misnamed
3 participants