Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Replace go-ping by pro-bing #11836

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Sep 19, 2022

Required for all PRs

The go-ping/ping package is going to be abandoned.

@Hipska Hipska added area/ping dependencies Pull requests that update a dependency file labels Sep 19, 2022
@telegraf-tiger telegraf-tiger bot added the chore label Sep 19, 2022
@Hipska Hipska marked this pull request as ready for review September 19, 2022 15:24
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this happened and migrating it to the new repository. Kind of a strange name lol

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 19, 2022
@SuperQ
Copy link

SuperQ commented Sep 20, 2022

Yea, we're planning to expand it to support other probe types. Like TCP or HTTP. We decided to go with a silly name. 😁

go.mod Outdated Show resolved Hide resolved
plugins/inputs/ping/ping.go Outdated Show resolved Hide resolved
plugins/inputs/ping/ping_test.go Outdated Show resolved Hide resolved
@reimda
Copy link
Contributor

reimda commented Sep 21, 2022

There is no notice on go-ping/ping that says it's abandoned. I see that prometheus-community/pro-bing has recent activity and I appreciate the work people are doing there. Can you share some background on why we should switch to the fork?

@Hipska
Copy link
Contributor Author

Hipska commented Sep 21, 2022

In their Slack Channel @SuperQ opted to archive it or at least mention it on the readme, but none of the maintainers responded to that. It is so abandoned that they even not care to inform the users 😉

@telegraf-tiger
Copy link
Contributor

@SuperQ
Copy link

SuperQ commented Sep 21, 2022

Yea, that's how difficult it is. Due to the dual approval necessary, I can't open a PR to even say that it's abandoned.

If either of you could open a PR to update the README, I could try and get it merged eventually.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @Hipska for your contribution!

@powersj powersj merged commit a2baab3 into influxdata:master Sep 26, 2022
@reimda
Copy link
Contributor

reimda commented Sep 27, 2022

And thanks @SuperQ for keeping the ping project alive with pro-bing

@Hipska Hipska deleted the chore/deps/ping branch September 30, 2022 08:37
popey pushed a commit that referenced this pull request Oct 3, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
@Hipska
Copy link
Contributor Author

Hipska commented Dec 23, 2022

@SuperQ do you have something in mind?

If either of you could open a PR to update the README, I could try and get it merged eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ping chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants