-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Replace go-ping by pro-bing #11836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this happened and migrating it to the new repository. Kind of a strange name lol
Yea, we're planning to expand it to support other probe types. Like TCP or HTTP. We decided to go with a silly name. 😁 |
There is no notice on go-ping/ping that says it's abandoned. I see that prometheus-community/pro-bing has recent activity and I appreciate the work people are doing there. Can you share some background on why we should switch to the fork? |
In their Slack Channel @SuperQ opted to archive it or at least mention it on the readme, but none of the maintainers responded to that. It is so abandoned that they even not care to inform the users 😉 |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Yea, that's how difficult it is. Due to the dual approval necessary, I can't open a PR to even say that it's abandoned. If either of you could open a PR to update the README, I could try and get it merged eventually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @Hipska for your contribution!
And thanks @SuperQ for keeping the ping project alive with pro-bing |
(cherry picked from commit a2baab3)
@SuperQ do you have something in mind?
|
Required for all PRs
The go-ping/ping package is going to be abandoned.