Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs): Linter issues #11576

Merged
merged 22 commits into from
Aug 2, 2022
Merged

fix(inputs): Linter issues #11576

merged 22 commits into from
Aug 2, 2022

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Aug 1, 2022

This PR fixes linter issues in plugins/inputs. After applying this only two issues in plugins/inputs/gnmi regarding deprecation of response.Error and gnmi.Error remain. However, fixing those is not straight forward and should be tackled in another PR.

srebhan added 21 commits August 1, 2022 16:45
@srebhan
Fix error messages for aliyuncms.
547bdf2
@srebhan
Fixup aliyuncms
5b40e31
@srebhan
Remove unused docker config.
21ef0be
@srebhan
Fix linter issues in docker.
0a9edb1
@srebhan
Fix one deprecated function in gnmi.
935654e
@srebhan
Remove unused variable in hddtemp.
dfdf869
@srebhan
Remove empty line.
8279094
@srebhan
Simplify code in ipmi_sensor test.
d07b5c7
@srebhan
Fix deprecated function in jti_openconfig_telemetry.
2ce712e
@srebhan
Silence linter error in kafka_consumer test.
4dab15e
@srebhan
Remove unused variable in kube_inventory.
0a9ad52
@srebhan
Remove unused variables in linux_sysctl_fs.
c09ff30
@srebhan
Simplify code in lvm test.
bdd1f29
@srebhan
Actively ignore returned errors in phpfpm to silence linter.
dcc8031
@srebhan
Comment black import in postgresql.
fa6043e
@srebhan
Remove unused JSON 'string' directive.
1e6a06e
@srebhan
Fix logging for snmp_legacy.
2ac72f7
@srebhan
Justify blank import for sqlite and remove superfluous file.
553a490
@srebhan
Refactor code in vsphere to not call defer in a loop.
ad571cd
@srebhan
Remove unused variable in vsphere test.
8f513e5
@srebhan
Allow usage of 'log' for plugins/inputs/zipkin/cmd.
a9ff54b
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Aug 1, 2022
@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Aug 1, 2022
@srebhan srebhan requested a review from zak-pawel August 1, 2022 15:50
powersj
powersj reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these. Can you mention what linter options you changed to see these issues?

zak-pawel
zak-pawel suggested changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@zak-pawel zak-pawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things...

@srebhan srebhan requested a review from zak-pawel August 2, 2022 07:25
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 2, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

zak-pawel
zak-pawel approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@zak-pawel zak-pawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srebhan srebhan merged commit e257846 into influxdata:master Aug 2, 2022
reimda pushed a commit that referenced this pull request Aug 15, 2022
@srebhan @reimda
fix(inputs): Linter issues (#11576)
d66adba 
(cherry picked from commit e257846)
reimda pushed a commit that referenced this pull request Aug 16, 2022
@srebhan @reimda
fix(inputs): Linter issues (#11576)
b542cad 
(cherry picked from commit e257846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@zak-pawel zak-pawel zak-pawel approved these changes

@MyaLongmire MyaLongmire MyaLongmire approved these changes

Assignees
No one assigned
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srebhan @powersj @zak-pawel @MyaLongmire