Adds CPU busy time and percentages #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil | ||
| } | ||
|
|
||
| func busyAndTotalCpuTime(t cpu.CPUTimesStat) (float64, float64) { |
There was a problem hiding this comment.
please document this function with a comment stating what the two float64 values are
|
@jpalay looks good I can merge once these few small things have been taken care of, and thank you for the thorough testing! |
| } | ||
|
|
||
| if totalDelta == 0 { | ||
| return nil |
There was a problem hiding this comment.
This should be continue instead of return nil, otherwise if we can't get percentages for one CPU then we get no stats at all for the rest.
sparrc
added a commit
that referenced
this pull request
Aug 13, 2015
sparrc
added a commit
that referenced
this pull request
Aug 13, 2015
|
I started working on some CPU things and wanted to get this in, so I went ahead and rebased it, made some small changes like those I commented on, and pushed thanks much @jpalay! |
|
Ok great, thanks! I also had some other thoughts about the CPU plugin, but I'll propose them in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CPU plugin now collects the percentage of time the processor spends in various areas. It does this by remembering the CPU metrics it gathered the last time telegraf ran the plugin. It then looks at the difference between the current CPU metrics and the CPU metrics gathered last in order to determine how the CPU has spent its time.
Also, because InfluxDB 0.9 does not support adding together values from different series, I updated the CPU plugin to also collect one calculated metric, busy time, which is just the sum of all the CPU metrics besides the idle time.