SQL Server Metrics V2 Add ProductVersion

[SteveKnowless]

Feature Request

Opening a feature request kicks off a discussion.

Proposal:

Add ProductVersion to V2 Metrics of SQL Input Plugin

Current behavior:

Unable to view SQL ProductVersion with V2 Metrics of SQL Input Plugin

Desired behavior:

View the ProductVersion

Use case: [Why is this important (helps with prioritizing requests)]

I would like to display the ProductVersion in my Grafana Dashboards

[danielnelson]

cc @m82labs

[m82labs]

The version number is currently collected already, 14.0.3025.34 for example. Are you looking for something else?

…

On Thu, Nov 29, 2018 at 17:35 Daniel Nelson ***@***.***> wrote: cc @m82labs <https://github.com/m82labs> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5067 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIS1dKFjs56StwDRWKmKPcyfwpm7hZ9Nks5u0GE3gaJpZM4Y6pRh> .

[SteveKnowless]

I do not get that with V2 of the Metrics Plugin. What I get and see is the "Engine_Edition" which returns an integer of the product edition (3 For Example). I was looking through the collection code of V2 and did not see anywhere for selecting the ProductVersion (14.0.3025.34) but I do see that in the V1 of the code. Did I maybe miss something? I also looked through my data and did not see anything similar to the ProductVersion being collected. Thanks for your help.

[m82labs]

I’ll look into this.

…

On Thu, Nov 29, 2018 at 18:17 SteveKnowless ***@***.***> wrote: I do not get that with V2 of the Metrics Plugin. What I get and see is the "Engine_Edition" which returns an integer based on the product edition (3 For Example). I was looking through the collection code of V2 and did not see anywhere for selecting the ProductVersion (14.0.3025.34) but I do see that in the V1 of the code. Did I maybe miss something? I also looked through my data and did not see anything similar to the ProductVersion being collected. Thanks for your help. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5067 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIS1dGIRBy5smOhoSBPLf-HeaZ6-k9d7ks5u0Gr7gaJpZM4Y6pRh> .

[m82labs]

This got removed accidentally. I am adding it back in a PR soon.

[SteveKnowless]

Awesome! Thanks a ton.

[m82labs]

I have a version built with these changes. I am going to eat lunch and let it collect data, make sure things look fine.

[danielnelson]

Closed by #5135