Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

chore: update azure dependencies #36

Closed
wants to merge 3 commits into from
Closed

chore: update azure dependencies #36

wants to merge 3 commits into from

Conversation

roeap
Copy link
Contributor

@roeap roeap commented Jun 17, 2022

This PR bumps the azure dependencies to latest.

Most notably the error handling in the azure SDKs improved significantly.

@roeap
Copy link
Contributor Author

roeap commented Jun 17, 2022

currently CI is failing due to an issue in the Azure SDKs Azure/azure-sdk-for-rust#823

@tustvold
Copy link
Contributor

tustvold commented Jun 27, 2022

I rebased this, but there still appears to be an upstream issue. #18 is looking mighty tempting 😅

@roeap
Copy link
Contributor Author

roeap commented Jun 27, 2022

Agreed, having a more focused implementation for communicating with the different APIs contained in this repo would be great! I even thought about getting this started here for azure, as I have a fairly good grasp about the azure APIs... the main thing stopping me from this is authorization. I guess when this is based on keys, some form of hmac (as mentioned in the description of #18 is all that is needed). However in almost all my applications we have to move to identitity based access, sometimes based on managed identities. My hope would therefore be that we can support oauth flows or provide some kind of token provider trait that we can implement externally to support these scenarios.

@roeap
Copy link
Contributor Author

roeap commented Jun 27, 2022

regarding the issue that blocks merging this ... i fixed it in the upstream crates and am hoping for another release soon. Will keep on monitoring the situation :)

@tustvold
Copy link
Contributor

the main thing stopping me from this is authorization

Yeah, I have some ideas on how to handle this. Perhaps I'll bash something out in the coming days 🤔

@alamb
Copy link
Contributor

alamb commented Jul 8, 2022

@roeap and @tustvold --

Given we plan to donate the object_store crate's code into the arrow-rs repo soon (TM) see apache/arrow-rs#2030, what is the plan for this PR? Will we merge it here prior to the donation or do you plan to retarget the changes to arrow-rs once it is there?

@roeap
Copy link
Contributor Author

roeap commented Jul 8, 2022

@alamb - this PR is currently blocked by a bug in the azure crates, which leads to ci failures. The bug is already fixed and we are waiting for a release. In can ask over there when that would be. I also plan to contribute an implementation of #18 for azure. I guess getting this one in would be nice to have, but should not block donating the crate. The work on the implementation using no azure dependencies should then happen in its new home. If we migrate before this one I would likely not re-open but go directly for #18.

@alamb
Copy link
Contributor

alamb commented Jul 8, 2022

👍 Thanks @roeap

We can simply wait to see what the schedule is -- and I am happy to help port this PR to a new repo if needed

@alamb
Copy link
Contributor

alamb commented Jul 26, 2022

The archiving of this crate is imminent -- see #52

@roeap shall we try and port this PR to arrow-rs so that it doesn't get lost? I am happy to help

@roeap
Copy link
Contributor Author

roeap commented Jul 26, 2022

@alamb - I thinks It's a good idea to take port this over. Was hoping to g directly for a local implementation, but not sure yet when I'll get to this. Should be able to get this done this weekend. I will also ping the people in the azure sdk again, to release the fixes so we can get this merged into arrow-rs repo.

@roeap roeap closed this by deleting the head repository Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants