Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the pidfile after the server has exited #1631

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Remove the pidfile after the server has exited #1631

merged 1 commit into from
Oct 27, 2017

Conversation

jsternberg
Copy link
Contributor

@jsternberg jsternberg commented Oct 20, 2017 •
edited by nathanielc
Loading

Fixes #1630.

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

@ghost ghost assigned jsternberg Oct 20, 2017
@ghost ghost added the in progress label Oct 20, 2017
@jsternberg jsternberg force-pushed the js-remove-pid-file branch 2 times, most recently from 6c01ec3 to 6f47d41 Compare October 20, 2017 15:20
@ghost ghost assigned nathanielc Oct 26, 2017
@nathanielc
Copy link
Contributor

@jsternberg Thanks for fixing this!

@nathanielc
Copy link
Contributor

nathanielc commented Oct 26, 2017 •
edited
Loading

@jsternberg I am getting this test failure:

--- FAIL: TestCommand_PIDFile (1.04s)
	command_test.go:62: unexpected timeout
FAIL

FYI, I rebased your branch to resolve a CHANGELOG conflict, so you will need to hard reset or force push again. Sorry for the trouble.

@jsternberg
Copy link
Contributor Author

I tried making the close timeout longer. Circle is probably just slower than my local computer.

@jsternberg
Copy link
Contributor Author

@nathanielc the test that I added passed the latest build, but something else panicked. Can you take a look?

@nathanielc nathanielc merged commit 6caca36 into master Oct 27, 2017
nathanielc added a commit that referenced this pull request Oct 27, 2017
@nathanielc
Merged pull request #1631 from influxdata/js-remove-pid-file
b1503ae 
Remove the pidfile after the server has exited
@ghost ghost removed the in progress label Oct 27, 2017
@nathanielc
Copy link
Contributor

@jsternberg Thanks!

@nathanielc nathanielc deleted the js-remove-pid-file branch October 27, 2017 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsternberg jsternberg

@nathanielc nathanielc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsternberg @nathanielc