Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fill(linear) when multiple series exist and there are null values #8149

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

jsternberg
Copy link
Contributor

@jsternberg jsternberg commented Mar 16, 2017

When there were multiple series and anything other than the last series
had any null values, the series would start using the first point from
the next series to interpolate points.

Interpolation should not cross between series. Now, the linear fill
checks to make sure the next point is within the same series before
using it to perform interpolation.

Fixes #8148.

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

When there were multiple series and anything other than the last series
had any null values, the series would start using the first point from
the next series to interpolate points.

Interpolation should not cross between series. Now, the linear fill
checks to make sure the next point is within the same series before
using it to perform interpolation.
Copy link
Contributor

@desa desa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsternberg jsternberg merged commit 003e113 into master Mar 16, 2017
@jsternberg jsternberg deleted the js-8148-fill-linear-order-by-desc branch March 16, 2017 21:13
@jwilder jwilder added this to the 1.3.0 milestone Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants