Allow selecting tag within subquery #8051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwilder this one isn't perfect, but it works for stopping the most common use case. The other use case it doesn't cover doesn't panic and uses a different code path. |
jsternberg
force-pushed
the
js-7968-panic-when-selecting-tag-from-inner-query
branch
from
6d25442 to
3b3541e
Compare
jwilder
suggested changes
Feb 23, 2017
influxql/iterator_mapper.go
Outdated
| @@ -26,7 +38,8 @@ func (itr *iteratorMapper) Next() (*FloatPoint, error) { | |||
|
|
|||
| itr.e.readInto(t, name, tags, itr.buf) | |||
| for i, f := range itr.fields { | |||
| itr.auxFields[i] = itr.buf[f] | |||
| //fmt.Println(i, f) | |||
jsternberg
force-pushed
the
js-7968-panic-when-selecting-tag-from-inner-query
branch
from
3b3541e to
1ce8fa2
Compare
jwilder
approved these changes
Feb 23, 2017
Previously, subqueries would only be able to select tag fields within a
subquery if the subquery used a selector. But, it didn't filter out
aggregates like `mean()` so it would panic instead.
Now it is possible to select the tag directly instead of rewriting the
query in an invalid way.
Some queries in this form will still not work though. For example, the
following still does not function (but also doesn't panic):
SELECT count(host) FROM (SELECT mean, host FROM (SELECT mean(value) FROM cpu GROUP BY host))
jsternberg
force-pushed
the
js-7968-panic-when-selecting-tag-from-inner-query
branch
from
1ce8fa2 to
72e4dd0
Compare
jsternberg
deleted the
js-7968-panic-when-selecting-tag-from-inner-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, subqueries would only be able to select tag fields within a
subquery if the subquery used a selector. But, it didn't filter out
aggregates like
mean()so it would panic instead.Now it is possible to select the tag directly instead of rewriting the
query in an invalid way.
Some queries in this form will still not work though. For example, the
following still does not function (but also doesn't panic):
Fixes #7968.