Fix subscriber service dropping writes under high write load #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
suggested changes
Oct 4, 2016
There was a problem hiding this comment.
This means that the PointsWriter implementations need to be safe for concurrent calls to WritePoints.
I checked and the existing implementation are, but we should add a comment to the Interface so that its clear for future implementations.
Just one small typo but otherwise this looks good to me.
| @@ -8,7 +8,9 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| DefaultHTTPTimeout = 30 * time.Second | |||
| DefaultHTTPTimeout = 30 * time.Second | |||
| DefaultWriteConcurrenty = 40 | |||
There was a problem hiding this comment.
Should this be DefaultWriteConcurrency?
The subscriber write goroutine would drop points if the write load was higher than it could process. This could happen with a just a few writers to the server. Instead, process the channel with multiple writers to avoid dropping writes so easily. This also adds some config options to control how large the channel buffer is as well as how many goroutines are started. Fixes #7330
|
@nathanielc Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
The subscriber write goroutine would drop points if the write load
was higher than it could process. This could happen with a just
a few writers to the server.
Instead, process the channel with multiple writers to avoid dropping
writes so easily. This also adds some config options to control how
large the channel buffer is as well as how many goroutines are started.
Fixes #7330
cc @nathanielc