Disable negative timestamps for writes #7205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change to the write API and needs to be called out in the breaking changes section of the changelog. |
The query engine does not support negative timestamps. Fixing that is too big of a change and we didn't intend to support timestamps before 1970 anyway. Disabling writes so that we can improve the query engine in the future to support negative timestamps.
jsternberg
force-pushed
the
js-7194-disable-negative-timestamps
branch
from
172671e to
d7578eb
Compare
|
Updated the changelog. |
|
I think we need to examine the fix for the query engine instead of preventing writes. |
|
Should this be closed now that #7212 has been merged? |
|
Yep. This isn't needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query engine does not support negative timestamps. Fixing that is
too big of a change and we didn't intend to support timestamps before
1970 anyway. Disabling writes so that we can improve the query engine in
the future to support negative timestamps.
Fixes #7194.