Bug fixes #7024
Merged
Bug fixes #7024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a delete is issued while a compaction is running, the a newly deleted series could re-appear after the compaction completed. This could occur the compaction had already written the blocks for series that were just deleted. When the compaction completes, the newly written tombstone files would be deleted, essentially undeleting the series.
Too verbose
A slower disk can can cause excessive allocations to occur when writing to the WAL because the slower encoding and compression occurs before taking the write lock. The encoding/compression grabs a large byte slice from a pool and ultimately waits until it can acquire the write lock. This adds a throttle to limit how many inflight WAL writes can be queued up to prevent OOMing the processess with slower disks and heavy writes.
| @@ -179,8 +177,6 @@ func (e *Engine) SetCompactionsEnabled(enabled bool) { | |||
|
|
|||
| // Wait for compaction goroutines to exit | |||
| e.wg.Wait() | |||
|
|
|||
| e.logger.Printf("compactions disabled for: %v", e.path) | |||
There was a problem hiding this comment.
Shall I add these back in when I get the trace logger comments done, and the PR merged?
There was a problem hiding this comment.
Trace logging for these would be good. Too verbose for regular logger though.
|
Just the nit about the package name, otherwise LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
This PR fixes a few bugs related to writes and deletes: