Properly use the 401 and 403 HTTP status codes #6978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-6959-403-forbidden-on-auth-failure
branch
from
bdce9d7 to
e821917
Compare
| @@ -27,5 +28,6 @@ func NewConfig() Config { | |||
| HTTPSEnabled: false, | |||
| HTTPSCertificate: "/etc/ssl/influxdb.pem", | |||
| MaxRowLimit: DefaultChunkSize, | |||
| Realm: "InfluxDB", | |||
There was a problem hiding this comment.
nit: should this be a constant like DefaultRealm?
|
minor nit, otherwise +1 |
jsternberg
force-pushed
the
js-6959-403-forbidden-on-auth-failure
branch
from
e821917 to
58f204f
Compare
According to the HTTP standard, a lack of authentication credentials or incorrect authentication credentials should send back a 401 (Unauthorized) with a `WWW-Authenticate` header with a challenge that can be used to authenticate. This is because a 401 status should be sent when an authentication attempt can be retried by the browser. The 403 (Forbidden) status code should be sent when authentication succeeded, but the user does not have the necessary authorization. Previously, the server would always send a 401 status code.
jsternberg
force-pushed
the
js-6959-403-forbidden-on-auth-failure
branch
from
58f204f to
7a3bd19
Compare
|
Great work. Thanks for the fast pickup of this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the HTTP standard, a lack of authentication credentials or
incorrect authentication credentials should send back a 401
(Unauthorized) with a
WWW-Authenticateheader with a challenge thatcan be used to authenticate. This is because a 401 status should be sent
when an authentication attempt can be retried by the browser.
The 403 (Forbidden) status code should be sent when authentication
succeeded, but the user does not have the necessary authorization.
Previously, the server would always send a 401 status code.
Fixes #6959.