Ensure meta SHOW queries include future points #6675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good to me. |
e-dard
force-pushed
the
er-future-meta
branch
4 times, most recently
from
6a539d7 to
a239896
Compare
This was referenced May 26, 2016
Closed
If all points in a series are timestamped in the future, the SHOW queries will not return anything from these series. This commit changes the to time used when querying shards for the SHOW queries to the maximum time, in order to ensure future points are considered in the results for these queries. Fixes #6599.
e-dard
force-pushed
the
er-future-meta
branch
2 times, most recently
from
2ef0c6c to
e6f525e
Compare
|
This will also fix #6740 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
Fixes #6599.
If a series only contained points in the future, then none of the
SHOWqueries would return anything. This was because theSHOWqueries were using the default time range (up tonow()) and the user is unable to specify a time clause to remedy that.SHOWqueries will now include a max time ofinfluxql.MaxTime.This PR also fixes the line-protocol parser to verify if the timestamp provided by the client is within the acceptable time period.