Fix parsing keys when loading database index #6500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return key[:idx] | ||
| // Ignoring the error because the func returns "missing fields" | ||
| k, _, _ := models.ParseKey(key) | ||
| return escape.UnescapeString(k) |
There was a problem hiding this comment.
Is this a breaking change? Looks like the keys were not previously unescaped.
There was a problem hiding this comment.
No, it has always been broken, but never discovered. This is called to parse a key already on disk.
|
Aside from my question about storing the keys, LGTM 👍 |
The code for parsing a key our of the WAL or TSM files in the engine was naive and didn't account for measurements with escape chars. This uses the correct parsing code to parse and load them correctly. Fixes #6496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
The code for parsing a key our of the WAL or TSM files in the engine
was naive and didn't account for measurements with escape chars. This
uses the correct parsing code to parse and load them correctly.
Fixes #6496