Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ShardGroupDuration checked when recreating an RP #6181

Merged
merged 1 commit into from
Apr 1, 2016
Merged

Ensure ShardGroupDuration checked when recreating an RP #6181

merged 1 commit into from
Apr 1, 2016

Conversation

e-dard
Copy link
Contributor

@e-dard e-dard commented Mar 31, 2016

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

Fixes #6178.

@e-dard e-dard modified the milestones: 0.13.0, 0.12.0 Mar 31, 2016
@jwilder
Copy link
Contributor

jwilder commented Mar 31, 2016 

[ERROR] run_tests: Code not formatted. Please use 'go fmt ./...' to fix formatting errors

@e-dard e-dard force-pushed the er-fix-recreate-rp branch from 6cd9c2c to 77c5d88 Compare April 1, 2016 10:06
@e-dard e-dard force-pushed the er-fix-recreate-rp branch from 77c5d88 to 712cc3f Compare April 1, 2016 10:59
@jwilder
Copy link
Contributor

jwilder commented Apr 1, 2016

👍

@e-dard e-dard merged commit 1d6b38c into master Apr 1, 2016
@e-dard e-dard deleted the er-fix-recreate-rp branch April 1, 2016 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@e-dard @jwilder