Fix remote execution for partially replicated clusters #5843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RPC handler for remote queries would attempt to reuse a closed connection for certain commands that didn't use pooling. The RPC commands that close the connection have been fixed to not try reusing the connection. When creating an iterator, if there are no points to return, the points decoder would hit an EOF that it didn't catch and would return that error back to the client who made the request. It now properly returns no points by using a `nilFloatIterator` if there are no points to return. This fixes remote execution when a cluster has nothing to return.
|
/cc @benbjohnson |
|
👍 |
jsternberg
added a commit
that referenced
this pull request
Feb 25, 2016
Fix remote execution for partially replicated clusters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC handler for remote queries would attempt to reuse a closed
connection for certain commands that didn't use pooling. The RPC
commands that close the connection have been fixed to not try reusing
the connection.
When creating an iterator, if there are no points to return, the points
decoder would hit an EOF that it didn't catch and would return that
error back to the client who made the request. It now properly returns
no points by using a
nilFloatIteratorif there are no points toreturn.
This fixes remote execution when a cluster has nothing to return.