Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix show_tag_keys in cluster mode #5101

Closed
wants to merge 4 commits into from
Closed

fix show_tag_keys in cluster mode #5101

wants to merge 4 commits into from

Conversation

CrazyJvm
Copy link
Contributor

fix issue: #3295

@CrazyJvm
Copy link
Contributor Author

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA

@CrazyJvm
Copy link
Contributor Author

@otoolep please help to review

@CrazyJvm CrazyJvm changed the title fix show_tag_keys fix show_tag_keys in cluster mode Dec 12, 2015
@CrazyJvm CrazyJvm mentioned this pull request Dec 12, 2015
Closed
@otoolep
Copy link
Contributor

otoolep commented Dec 12, 2015

cc @dgnorton

otoolep
otoolep reviewed Dec 12, 2015
View reviewed changes
CHANGELOG.md
@@ -12,6 +12,7 @@ With this release InfluxDB is moving to Go 1.5.
- [#4622](https://github.com/influxdb/influxdb/issues/4622): Fix panic when passing too large of timestamps to OpenTSDB input.
- [#5064](https://github.com/influxdb/influxdb/pull/5064): Full support for parenthesis in SELECT clause, fixes [#5054](https://github.com/influxdb/influxdb/issues/5054). Thanks @mengjinglei
- [#5079](https://github.com/influxdb/influxdb/pull/5079): Ensure tsm WAL encoding buffer can handle large batches.
- [#5101](https://github.com/influxdb/influxdb/pull/5101): Fix `show tag keys` in cluster mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "Thanks @CrazyJvm " to this line!

@CrazyJvm
Copy link
Contributor Author

Any feedback to this PR?

@otoolep
Copy link
Contributor

otoolep commented Dec 22, 2015

Bump @dgnorton

@dgnorton
Copy link
Contributor

@CrazyJvm can you add integration test(s) that fail without this fix and pass with it? The test(s) would go in cmd/influxd/run. It's possible that you just need to add it to server_suite_test.go. Thanks!

@krogon-intel
Copy link

I still got failure with this fix
2016/01/27 15:53:57 failure getting snapshot from 10.0.0.2:8088: Get http://10.0.0.2:8088?index=0: read tcp 10.0.0.1:47388->10.0.0.2:8088: read: connection reset by peer

@jwilder
Copy link
Contributor

jwilder commented Feb 10, 2016

#5196 changed the query engine substantially so this PR is not able to be merged as is. We are still fixing remote query execution due to the changes in #5196, but when that is complete, show tag keys should work. We're tracking the cluster meta-queries in #5581.

@jwilder jwilder closed this Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CrazyJvm @otoolep @dgnorton @krogon-intel @jwilder