Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue preventing build in Windows #5070

Closed
wants to merge 1 commit into from

Conversation

mvadu
Copy link
Contributor

@mvadu mvadu commented Dec 9, 2015

Removed nil in line#13 return which was stopping the build in Windows. src\github.com\influxdb\influxdb\tsdb\engine\tsm1\mmap_windows.go:13: too many arguments to return issue is fixed.

It will fix #4358 but will not let tsm1 to run on Windows. At least users can test other improvements and bug fixes from 0.9.6

Removed nil in return which was stopping the build in Windows. `src\github.com\influxdb\influxdb\tsdb\engine\tsm1\mmap_windows.go:13: too many arguments to return` issue is fixed.
@jwilder
Copy link
Contributor

jwilder commented Dec 9, 2015

@mvadu There is a PR that should allow windows to work, but the tests fail on windows. #5039

@mvadu
Copy link
Contributor Author

mvadu commented Dec 9, 2015

@jwilder Yup, I myself implemented the mmap logic in #4981 (which is used as is in #5039), but it will alone won't make tsm work as rename while file is in use is not liked by Windows.

@jwilder
Copy link
Contributor

jwilder commented Dec 9, 2015

@mvadu Have you tried with latest? 99c313d fixed a file leak which might have prevented the rename. If it still occurs, then we can re-work how the renaming works. The files should be closed while the rename runs though.

@mvadu
Copy link
Contributor Author

mvadu commented Dec 9, 2015

@jwilder Yes, I just posted an update there with latest head from master branch, with my changes. Please check #4981

@mvadu
Copy link
Contributor Author

mvadu commented Jan 13, 2016

Closed in #4981

@mvadu mvadu closed this Jan 13, 2016
@mvadu mvadu deleted the mvadu-patch-4358-1 branch January 13, 2016 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSM engine breaks windows compatibility
2 participants