Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-client: changed statements' Err type to string, tagged by error #5059

Merged
merged 1 commit into from
Dec 9, 2015
Merged

go-client: changed statements' Err type to string, tagged by error #5059

merged 1 commit into from
Dec 9, 2015

Conversation

farshidtz
Copy link
Contributor

The HTTP API json response in case of errors has "error": "string" format. The Go client was instead looking for err key and an error typed value.

Sample error responses from InfluxDB v0.9.5.1:

{
  "error": "error parsing query: found EOF, expected identifier at line 1, char 35"
}
{
  "results": [
    {
      "error": "retention policy duration must be at least 1h0m0s"
    }
  ]
}

@otoolep
Copy link
Contributor

otoolep commented Dec 9, 2015

Thanks @farshidtz -- I see you have signed the CLA.

+1

@sparrc @corylanou

@sparrc
Copy link
Contributor

sparrc commented Dec 9, 2015

+1 LGTM

@otoolep
Copy link
Contributor

otoolep commented Dec 9, 2015

Thanks @farshidtz

otoolep added a commit that referenced this pull request Dec 9, 2015
go-client: changed statements' Err type to string, tagged by `error`
@otoolep otoolep merged commit 646573e into influxdata:master Dec 9, 2015
@farshidtz
Copy link
Contributor Author

@otoolep It's the least I could do.

@jwilder jwilder added this to the 0.10.0 milestone Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants