fix #4276: shouldn't drop all series when regex doesn't match #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2822,6 +2822,10 @@ func Walk(v Visitor, node Node) { | |||
| Walk(v, c) | |||
| } | |||
|
|
|||
| case *DropSeriesStatement: | |||
There was a problem hiding this comment.
While we're in here, should we add a panic for unsupported cases? Or can this be called for unsupported cases during normal operation?
There was a problem hiding this comment.
Some statement types don't need to be represented as a case because they have no members that can be walked. If we added a panic then each of those would have to have an empty case. But, doing that still wouldn't prevent this type of bug because we still have to remember to update the Walk function if a walkable member is added to one of the types.
|
+1, tests look fine. Of course, this was a pretty simple issue, I commented about the |
dgnorton
added a commit
that referenced
this pull request
Oct 6, 2015
fix #4276: shouldn't drop all series when regex doesn't match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.