Remove unused buffer allocation #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffer allocation in bz1 was unused and I'm fairly certain that it was harmful to performance if used. For queries that run through a bz1 block, needing to hold on to a 64kb block is expensive. Better to churn on the allocator and have the blocks be released when they are unused than to have 64kb hanging around for each series regardless of size. Thanks to @jwilder for brainstorming this issue with me.
|
If it's unused, nuke it. +1. |
|
👍 |
|
👍 |
DanielMorsing
added a commit
that referenced
this pull request
Aug 25, 2015
Remove unused buffer allocation
|
@DanielMorsing -- please confirm cherry-pick to 0.9.3 here when it happens. |
|
pushed to 0.9.3 at f30e2d8 |
This was referenced Aug 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer allocation in bz1 was unused and I'm fairly certain that it
was harmful to performance if used. For queries that run through a bz1
block, needing to hold on to a 64kb block is expensive. Better to churn
on the allocator and have the blocks be released when they are unused
than to have 64kb hanging around for each series regardless of size.
Thanks to @jwilder for brainstorming this issue with me.