-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add partial param v1 #25126
base: main
Are you sure you want to change the base?
feat: add partial param v1 #25126
Changes from 1 commit
5b0e339
7e610e7
2cbde5f
6ad9462
25f05a6
53a1bb6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1003,10 +1003,12 @@ async fn api_v1_query_chunked() { | |
"values": [ | ||
[1, "a", 0.9], | ||
[2, "a", 0.89], | ||
] | ||
], | ||
"partial": true | ||
} | ||
], | ||
"statement_id": 0 | ||
"statement_id": 0, | ||
"partial": true | ||
} | ||
] | ||
}), | ||
|
@@ -1044,10 +1046,12 @@ async fn api_v1_query_chunked() { | |
[1, "a", 0.9], | ||
[2, "a", 0.89], | ||
[3, "a", 0.85] | ||
] | ||
], | ||
"partial": true | ||
} | ||
], | ||
"statement_id": 0 | ||
"statement_id": 0, | ||
"partial": true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this test case it did not work correctly, because there are no more results for the |
||
} | ||
] | ||
}), | ||
|
@@ -1086,10 +1090,12 @@ async fn api_v1_query_chunked() { | |
"values": [ | ||
[1, "a", 0.9], | ||
[2, "a", 0.89], | ||
] | ||
], | ||
"partial": true | ||
} | ||
], | ||
"statement_id": 0 | ||
"statement_id": 0, | ||
"partial": true | ||
Comment on lines
+1092
to
+1097
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one is correct ✅ |
||
} | ||
] | ||
}), | ||
|
@@ -1102,10 +1108,12 @@ async fn api_v1_query_chunked() { | |
"columns": ["time","host","usage"], | ||
"values": [ | ||
[3, "a", 0.85] | ||
] | ||
], | ||
"partial": true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one is not correct, as there are no more records for |
||
} | ||
], | ||
"statement_id": 0 | ||
"statement_id": 0, | ||
"partial": true | ||
Comment on lines
+1113
to
+1114
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one is correct, as there are more records for the statement. |
||
} | ||
] | ||
}), | ||
|
@@ -1119,10 +1127,12 @@ async fn api_v1_query_chunked() { | |
"values": [ | ||
[4, "a", 0.5], | ||
[5, "a", 0.6], | ||
] | ||
], | ||
"partial": true | ||
} | ||
], | ||
"statement_id": 0 | ||
"statement_id": 0, | ||
"partial": true | ||
Comment on lines
+1128
to
+1133
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both of these are incorrect, as there are no more records for the measurement or statement. |
||
} | ||
] | ||
}), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this test case, it worked correctly ✅