Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add error message when attempting to delete by field #24131

Merged
merged 2 commits into from
Mar 10, 2023
Merged

fix: add error message when attempting to delete by field #24131

merged 2 commits into from
Mar 10, 2023

Conversation

jeffreyssmith2nd
Copy link
Contributor

Description

The current error message implies there is an issue with the query. This more explicitly explains that this is not a supported feature.

Note for reviewers:

Check the semantic commit type:

  • Feat: a feature with user-visible changes
  • Fix: a bug fix that we might tell a user “upgrade to get this fix for your issue”
  • Chore: version bumps, internal doc (e.g. README) changes, code comment updates, code formatting fixes… must not be user facing (except dependency version changes)
  • Build: build script changes, CI config changes, build tool updates
  • Refactor: non-user-visible refactoring
  • Check the PR title: we should be able to put this as a one-liner in the release notes

@jeffreyssmith2nd jeffreyssmith2nd marked this pull request as ready for review March 8, 2023 19:29
davidby-influx
davidby-influx approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffreyssmith2nd jeffreyssmith2nd merged commit e1d0102 into master Mar 10, 2023
@jeffreyssmith2nd jeffreyssmith2nd deleted the smith/delete-by-field branch March 10, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidby-influx davidby-influx davidby-influx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffreyssmith2nd @davidby-influx