chore: update protobuf library versions and remove influx_tsm #21882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
reviewed
Jul 19, 2021
build.py
Outdated
| @@ -189,6 +189,14 @@ def run_tests(race, parallel, timeout, no_vet, junit=False): | |||
| logging.error("Code not formatted. Please use 'goimports -w ./' to fix formatting errors.") | |||
| logging.error("{}".format(out)) | |||
| return False | |||
|
|
|||
| logging.info("Ensuring code is properly formatted with goimports ...") | |||
There was a problem hiding this comment.
Logs need updated? Look like copy-paste from the lines above
lesam
force-pushed
the
update-proto
branch
3 times, most recently
from
321bb69 to
b362fa5
Compare
lesam
commented
Jul 20, 2021
| @@ -45,7 +24,7 @@ var _ = time.Kitchen | |||
| // is compatible with the proto package it is being compiled against. | |||
| // A compilation error at this line likely means your copy of the | |||
| // proto package needs to be updated. | |||
| const _ = proto.GoGoProtoPackageIsVersion2 // please upgrade the proto package | |||
| const _ = proto.GoGoProtoPackageIsVersion3 // please upgrade the proto package | |||
There was a problem hiding this comment.
We are in fact using the newest version of github.com/gogo/protobuf/proto, so this is safe.
danxmoran
approved these changes
Jul 20, 2021
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Jul 20, 2021
…data#21882) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Jul 20, 2021
…data#21882) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm
4 tasks
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Jul 20, 2021
…data#21882) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Jul 20, 2021
…data#21882) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Jul 20, 2021
…data#21882) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Jul 20, 2021
…data#21882) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm
lesam
added a commit
that referenced
this pull request
Jul 20, 2021
#21890) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Jul 20, 2021
…data#21882) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm
lesam
added a commit
that referenced
this pull request
Jul 20, 2021
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Jul 21, 2021
…data#21882) (influxdata#21891) * chore: update protobuf library versions and remove influx_tsm (influxdata#21882) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm * fix: codegen works * fix: add tools.go for 1.8 (cherry picked from commit 51600c8)
4 tasks
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Jul 21, 2021
…data#21882) (influxdata#21891) * chore: update protobuf library versions and remove influx_tsm (influxdata#21882) * chore: update protobufs * fix: run codegen during build * fix: fully remove influx_tsm * fix: codegen works * fix: add tools.go for 1.8 (cherry picked from commit 51600c8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update library versions. Also remove old code for
influx_tsm, now found at https://github.com/influxdata/influx_tsm