-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Port influxd inspect verify-tsm #21615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a few more thoughts. @dgnorton would be a good person to weigh in on the test cases here to judge if they're covering the cases we expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main code LGTM! I've asked @dgnorton to sanity-check the tests in case we're missing some details
4284130
to
c85b950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final suggestions but LGTM overall!
9b91a5b
to
a1def86
Compare
Closes #19536
Describe your proposed changes here.
This PR ports the
influxd inspect verify-tsm
command from 1.x to v2. I also added averbose
flag since I thought it might be helpful since there was a lot of logging output on a database of substantial size. Additionally, there were previously no test cases, so I created some for this command, though they could probably use some work. The functional logic of the command is mostly untouched, with the work being in porting to Cobra and writing the test cases.