feat: enable the notebooks backend #21613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhbaker
force-pushed
the
wb-enable-notebooks-backend-21266
branch
from
77e3936 to
47358a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21266
What this PR does is:
notebooksfeature flags are off.notebooksApifeature flag to default to true. This will ensure that the notebooks frontend, if enabled, will make the compatible API calls for the notebooks service implemented by the OSS backend.notebooksflag default to false. This will leave the "books" button hidden on the UI sidebar, effectively keeping the notebooks feature hidden. It is being kept hidden for now since the backup/restore CLI functions are not yet complete to allow for backing up and restoring notebooks data.Doing the above will allow the notebooks feature to be toggled from the frontend. This should let us enable the end-to-end tests for notebooks. The tests themselves toggle the
notebooksflag on as they run. Enabling these tests will give us more assurance that the notebooks feature is working as intended on OSS.I'm opting to not add a
CHANGELOGentry yet since the feature is still hidden - once thenotebooksflag is set totrue, theCHANGELOGwill be updated for the notebooks feature.