fix: Anti-Entropy loops endlessly with empty shard #21275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The anti-entropy service will loop trying to copy an empty shard to a data node missing that shard. This fix is one of two changes that correctly create an empty shard on a new node. This fix will set the LastModified date of an empty shard directory to the modificaiton time of that directory, instead of to the Unix epoch. Fixes: #21273
dgnorton
reviewed
Apr 22, 2021
| } | ||
| if isEmpty { | ||
| if fi, err := os.Stat(f.dir); err == nil { | ||
| f.lastModified = fi.ModTime().UTC() |
There was a problem hiding this comment.
Does it need to account for tombstones? I'm not sure. TSMReader appears to: https://github.com/influxdata/influxdb/blob/master-1.x/tsdb/engine/tsm1/reader.go#L527
There was a problem hiding this comment.
I think it does account for tombstones. In the loop here, res.r.LastModfied() checks the tombstones, so the directory modification time is only used if the readerC channel is completely empty.
This was referenced Apr 23, 2021
davidby-influx
added a commit
that referenced
this pull request
Apr 23, 2021
The anti-entropy service will loop trying to copy an empty shard to a data node missing that shard. This fix is one of two changes that correctly create an empty shard on a new node. This fix will set the LastModified date of an empty shard directory to the modification time of that directory, instead of to the Unix epoch. Fixes: #21273 (cherry picked from commit 7f300dc)
davidby-influx
added a commit
that referenced
this pull request
Apr 26, 2021
The anti-entropy service will loop trying to copy an empty shard to a data node missing that shard. This fix is one of two changes that correctly create an empty shard on a new node. This fix will set the LastModified date of an empty shard directory to the modification time of that directory, instead of to the Unix epoch. Fixes: #21273 (cherry picked from commit 7f300dc)
davidby-influx
added a commit
that referenced
this pull request
Apr 27, 2021
The anti-entropy service will loop trying to copy an empty shard to a data node missing that shard. This fix is one of two changes that correctly create an empty shard on a new node. This fix will set the LastModified date of an empty shard directory to the modification time of that directory, instead of to the Unix epoch. Fixes: #21273 (cherry picked from commit 7f300dc)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anti-entropy service will loop trying to copy an empty shard to a
data node missing that shard. This fix is one of two changes that
correctly create an empty shard on a new node.
Fixes: #21273
This fix will set the LastModified date of an empty shard directory to the
modification time of that directory, instead of to the Unix epoch.