feat(telemetry): replace unique ids for resources with a slug #21158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhbaker
force-pushed
the
wb-telemetry-improvements-20920
branch
from
53b4e52 to
a2237db
Compare
danxmoran
approved these changes
Apr 7, 2021
Yep the existing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20920
#20920 mentions paths in the form of
/api/v2/backup/99/file/000000000007376-000000001.tsm. The current backup and restore process does not generate calls to this kind of path, so no change was needed for those.UI asset files names are replaced with a slug in the form of
:file_name.ext, whereextis the file extension (.js,.svg, etc.).Shard IDs used in requests related to backups & restores are replaced with
:shard_id, rather than a unique numerical ID.