feat: updating telegraf plugins for latest release #20861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russorat
force-pushed
the
telegraf-plugin-updates-mar-2021
branch
from
5617975 to
b82a8ff
Compare
danxmoran
reviewed
Mar 15, 2021
There was a problem hiding this comment.
@russorat we need to remove the references to old settings. I tried removing the references from telegraf's code in influxdata/telegraf#8754 after your last PR, but the change wasn't accepted since the advice is still relevant for older InfluxDBs
| @@ -13,6 +13,9 @@ your database. | |||
| options to exclude unneeded tags. | |||
| - Write to a database with an appropriate | |||
| [retention policy](https://docs.influxdata.com/influxdb/latest/guides/downsampling_and_retention/). | |||
| - Limit series cardinality in your database using the | |||
| [`max-series-per-database`](https://docs.influxdata.com/influxdb/latest/administration/config/#max-series-per-database-1000000) and | |||
| [`max-values-per-tag`](https://docs.influxdata.com/influxdb/latest/administration/config/#max-values-per-tag-100000) settings. | |||
There was a problem hiding this comment.
Needs reverted since these are gone in 2.0.4+
| @@ -27,6 +27,8 @@ avoid cardinality issues: | |||
|
|
|||
| - Use [metric filtering][] options to exclude unneeded measurements and tags. | |||
| - Write to a database with an appropriate [retention policy][]. | |||
| - Limit series cardinality in your database using the | |||
| [max-series-per-database][] and [max-values-per-tag][] settings. | |||
| @@ -307,6 +309,8 @@ kubernetes_statefulset,namespace=default,selector_select1=s1,statefulset_name=et | |||
|
|
|||
| [metric filtering]: https://github.com/influxdata/telegraf/blob/master/docs/CONFIGURATION.md#metric-filtering | |||
| [retention policy]: https://docs.influxdata.com/influxdb/latest/guides/downsampling_and_retention/ | |||
| [max-series-per-database]: https://docs.influxdata.com/influxdb/latest/administration/config/#max-series-per-database-1000000 | |||
| [max-values-per-tag]: https://docs.influxdata.com/influxdb/latest/administration/config/#max-values-per-tag-100000 | |||
| @@ -28,6 +28,8 @@ avoid cardinality issues: | |||
|
|
|||
| - Use [metric filtering][] options to exclude unneeded measurements and tags. | |||
| - Write to a database with an appropriate [retention policy][]. | |||
| - Limit series cardinality in your database using the | |||
| [max-series-per-database][] and [max-values-per-tag][] settings. | |||
| @@ -152,6 +154,8 @@ kubernetes_system_container | |||
|
|
|||
| [metric filtering]: https://github.com/influxdata/telegraf/blob/master/docs/CONFIGURATION.md#metric-filtering | |||
| [retention policy]: https://docs.influxdata.com/influxdb/latest/guides/downsampling_and_retention/ | |||
| [max-series-per-database]: https://docs.influxdata.com/influxdb/latest/administration/config/#max-series-per-database-1000000 | |||
| [max-values-per-tag]: https://docs.influxdata.com/influxdb/latest/administration/config/#max-values-per-tag-100000 | |||
| @@ -15,6 +15,9 @@ manage your series cardinality: | |||
| `tagexclude` to remove the `pid` and `process_group_id` tags. | |||
| - Write to a database with an appropriate | |||
| [retention policy](https://docs.influxdata.com/influxdb/latest/guides/downsampling_and_retention/). | |||
| - Limit series cardinality in your database using the | |||
| [`max-series-per-database`](https://docs.influxdata.com/influxdb/latest/administration/config/#max-series-per-database-1000000) and | |||
| [`max-values-per-tag`](https://docs.influxdata.com/influxdb/latest/administration/config/#max-values-per-tag-100000) settings. | |||
| @@ -14,6 +14,8 @@ avoid cardinality issues: | |||
|
|
|||
| - Use [metric filtering][] options to exclude unneeded measurements and tags. | |||
| - Write to a database with an appropriate [retention policy][]. | |||
| - Limit series cardinality in your database using the | |||
| [max-series-per-database][] and [max-values-per-tag][] settings. | |||
| @@ -111,6 +113,8 @@ This sflow implementation was built from the reference document | |||
|
|
|||
| [metric filtering]: https://github.com/influxdata/telegraf/blob/master/docs/CONFIGURATION.md#metric-filtering | |||
| [retention policy]: https://docs.influxdata.com/influxdb/latest/guides/downsampling_and_retention/ | |||
| [max-series-per-database]: https://docs.influxdata.com/influxdb/latest/administration/config/#max-series-per-database-1000000 | |||
| [max-values-per-tag]: https://docs.influxdata.com/influxdb/latest/administration/config/#max-values-per-tag-100000 | |||
|
@danxmoran i'd like to keep the readme content the same if possible between the telegraf repo and the product, otherwise it will become even more unmaintainable going forward. I've commented on the other PR to see if we can change those links to go to the docs pages instead. |
danxmoran
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Describe your proposed changes here.