fix(query): Group By queries with offset that crosses a DST boundary can fail #20230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can fail Customer reported that a GROUP BY query with an offset that caused an interval to cross a daylight savings change inserted an extra output row off by one hour. This fix ensured that the start time for the interval of a GROUP BY operator is correctly set before calculating the time zone offset for that date and time.
gshif
previously approved these changes
Dec 2, 2020
jsternberg
suggested changes
Dec 2, 2020
| @@ -815,6 +815,8 @@ func (opt IteratorOptions) Window(t int64) (start, end int64) { | |||
| start = t - dt | |||
| } | |||
|
|
|||
| start += int64(opt.Interval.Offset) | |||
There was a problem hiding this comment.
Can you add some tests for this behavior?
There was a problem hiding this comment.
Can do. @gshif developed a truly minimal repro case I can encapsulate in a test.
…can fail Customer reported that a GROUP BY query with an offset that caused an interval to cross a daylight savings change inserted an extra output row off by one hour. This fix ensured that the start time for the interval of a GROUP BY operator is correctly set before calculating the time zone offset for that date and time. Fixes #20238
…influxdb into DSB_influxdb_EAR1855
Add a regression test for #20238 to ensure that GROUP BY queries operate correctly when their Interval.Offset causes them to cross daylight savings time boundaries.
|
Added a regression test, TestGroupByIterator_DST() in query/iterator_test.go. @jsternberg, take a look at your convenience. |
jsternberg
approved these changes
Dec 4, 2020
davidby-influx
added a commit
that referenced
this pull request
Dec 7, 2020
…can fail (#20230) * fix(query): Group By queries with offset that crosses a DST boundary can fail Customer reported that a GROUP BY query with an offset that caused an interval to cross a daylight savings change inserted an extra output row off by one hour. This fix ensured that the start time for the interval of a GROUP BY operator is correctly set before calculating the time zone offset for that date and time. Add TestGroupByIterator_DST() in query/iterator_test.go for regression testing of this bug. Fixes #20238 (cherry picked from commit df39b1e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer reported that a GROUP BY query with an offset that caused an interval
to cross a daylight savings change inserted an extra output row off by one hour.
This fix ensured that the start time for the interval of a GROUP BY operator is
correctly set before calculating the time zone offset for that date and time.
Fixes #20238