Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): don't log bodies of V1 write requests #20151

Merged
merged 2 commits into from
Nov 23, 2020
Merged

fix(http): don't log bodies of V1 write requests #20151

merged 2 commits into from
Nov 23, 2020

Conversation

danxmoran
Copy link
Contributor

Closes #19978

docmerlin
docmerlin approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@docmerlin docmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. This was bad.

@docmerlin docmerlin merged commit aa0defe into master Nov 23, 2020
@docmerlin docmerlin deleted the dm-debug-log-no-body-19978 branch November 23, 2020 20:45
@docmerlin docmerlin added area/2.x OSS 2.0 related issues and PRs kind/bug labels Nov 23, 2020
@danxmoran danxmoran mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@docmerlin docmerlin docmerlin approved these changes

Assignees
No one assigned
Labels
area/2.x OSS 2.0 related issues and PRs kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

debug log prints unicode characters instead of human-readable data
2 participants
@danxmoran @docmerlin