fix: Allow self signed certificates to ScraperTarget #20047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmackenzie1
force-pushed
the
scraper-self-signed-certificates
branch
from
202fbe4 to
80c04b2
Compare
cmackenzie1
changed the title
glinton
suggested changes
Nov 16, 2020
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| 1. [19987](https://github.com/influxdata/influxdb/pull/19987): Fix various typos. Thanks @kumakichi! | |||
| 1. [19991](https://github.com/influxdata/influxdb/pull/19991): Use --skip-verify flag for backup/restore CLI command. | |||
| 1. [19995](https://github.com/influxdata/influxdb/pull/19995): Don't auto-print help on influxd errors | |||
| 1. [20047](https://github.com/influxdata/influxdb/pull/20047): Allow InsecureSkipVerify to be specified on ScraperTarget's | |||
There was a problem hiding this comment.
nit: maybe Allow scraper to ignore insecure certificates on a target or
Suggested change
| 1. [20047](https://github.com/influxdata/influxdb/pull/20047): Allow InsecureSkipVerify to be specified on ScraperTarget's | |
| 1. [20047](https://github.com/influxdata/influxdb/pull/20047): Allow InsecureSkipVerify to be specified on a ScraperTarget |
|
Thanks @cmackenzie1! I'll merge once the build goes green, it'll be included in our next release |
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
Co-authored-by: Daniel Moran <[email protected]>
8 tasks
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
Co-authored-by: Daniel Moran <[email protected]>
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
This reverts commit b337d42.
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
Co-authored-by: Daniel Moran <[email protected]>
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
Co-authored-by: Daniel Moran <[email protected]>
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
Co-authored-by: Daniel Moran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20045
Adding a new optional field,
allowInsecurewith the default value offalseto the APIPOST /api/v2/scrapersUsing the new
allowInsecurefield to theGather()method