Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow self signed certificates to ScraperTarget #20046

Closed
wants to merge 9 commits into from
Closed

Allow self signed certificates to ScraperTarget #20046

wants to merge 9 commits into from

Conversation

cmackenzie1
Copy link
Contributor

Closes #20045

  • Adding a new optional field, allowInsecure with the default value of false to the API POST /api/v2/scrapers

  • Using the new allowInsecure field to the Gather() method

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@cmackenzie1 cmackenzie1 requested a review from a team as a code owner November 16, 2020 05:37
@gg-g gg-g mentioned this pull request May 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scraper does not allow self-signed certificates.
4 participants
@cmackenzie1 @gshif @danxmoran @benbjohnson