Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Cloning tasks makes actions shared in task list view #19685

Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix(ui): Cloning tasks makes actions shared in task list view #19685

merged 1 commit into from
Nov 5, 2020

Conversation

omarsy
Copy link
Contributor

@omarsy omarsy commented Oct 4, 2020 •
edited
Loading

Closes #18478

Describe your proposed changes here.

@omarsy omarsy changed the title use newtask for copy Bug: Cloning tasks makes actions shared in task list view Oct 4, 2020
@omarsy omarsy changed the title Bug: Cloning tasks makes actions shared in task list view Fix: Cloning tasks makes actions shared in task list view Oct 4, 2020
@omarsy omarsy force-pushed the issue-18478 branch 2 times, most recently from 8995235 to 9a9fec3 Compare October 4, 2020 17:59
@omarsy omarsy changed the title Fix: Cloning tasks makes actions shared in task list view Fix(UI): Cloning tasks makes actions shared in task list view Oct 4, 2020
@omarsy omarsy changed the title Fix(UI): Cloning tasks makes actions shared in task list view fix(ui): Cloning tasks makes actions shared in task list view Oct 4, 2020
@russorat russorat requested review from a team and asalem1 and removed request for a team November 5, 2020 18:14
@russorat
Copy link
Contributor

russorat commented Nov 5, 2020

@omarsy thank you for submitting this!

121watts
121watts approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@121watts 121watts merged commit 7d6026e into influxdata:master Nov 5, 2020
asalem1
asalem1 approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@asalem1 asalem1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalem1 asalem1 asalem1 approved these changes

@121watts 121watts 121watts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloning tasks makes actions shared in task list view
4 participants
@omarsy @russorat @121watts @asalem1