Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): revert #19246 #19336

Merged
merged 1 commit into from
Aug 15, 2020
Merged

fix(ui): revert #19246 #19336

merged 1 commit into from
Aug 15, 2020

Conversation

alexpaxton
Copy link
Contributor

This reverts commit 67857f2.

Closes #

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

drdelambre
drdelambre approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try again on monday!

@alexpaxton alexpaxton merged commit 0111f02 into master Aug 15, 2020
alexpaxton added a commit that referenced this pull request Aug 17, 2020
@alexpaxton
Revert "Revert "feat(ui): redesign load data page (#19246)" (#19336)"
1744d98 
This reverts commit 0111f02.
alexpaxton added a commit that referenced this pull request Aug 18, 2020
@alexpaxton
feat(ui): new load data page (#19351)
ebf41ec 
* Revert "Revert "feat(ui): redesign load data page (#19246)" (#19336)"

This reverts commit 0111f02.

* fix: guard against no tokens or buckets

* fix: typo

* refactor: name sources page titles properly

* fix: avoid referencing image asset inline
Cubone21 pushed a commit that referenced this pull request Aug 25, 2020
@alexpaxton @Cubone21
Revert "feat(ui): redesign load data page (#19246)" (#19336)
4cd7277 
This reverts commit 67857f2.
Cubone21 pushed a commit that referenced this pull request Aug 25, 2020
@alexpaxton @Cubone21
feat(ui): new load data page (#19351)
29673e7 
* Revert "Revert "feat(ui): redesign load data page (#19246)" (#19336)"

This reverts commit 0111f02.

* fix: guard against no tokens or buckets

* fix: typo

* refactor: name sources page titles properly

* fix: avoid referencing image asset inline
@jacobmarble jacobmarble deleted the fix/revert-load-data branch January 2, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdelambre drdelambre drdelambre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpaxton @drdelambre