Creating Infinite Retention Policy Failed #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1918 |
|
👍 |
|
I now think we should a value other than 0 to indicate infinite duration, but we can come back to that. +1. |
|
Thanks @corylanou |
|
I want to add more integration-level testing now, so I'm merging this. |
otoolep
added a commit
that referenced
this pull request
Mar 11, 2015
Creating Infinite Retention Policy Failed
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
…creation Fix(ui/dataLoaders): Hide download button if there's nothing to download
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to a bug that @jnutzmann logged on PR #1902. We were missing some test coverage on INF retention policy which I've added, and corrected the calculations for min shard duration.
Thanks @jnutzmann!