feat(pkger): add resource links to a stack's resources from public HTTP API list/read calls

CHANGELOG.md

@@ -4,6 +4,10 @@
 
 1. [19066](https://github.com/influxdata/influxdb/pull/19066): Drop deprecated /packages route tree
 
+### Features
+
+1. [19075](https://github.com/influxdata/influxdb/pull/19075): Aadd resource links to a stack's resources from public HTTP API list/read calls
+
 ### Bug Fixes
 
 1. [19043](https://github.com/influxdata/influxdb/pull/19043): Enforce all influx CLI flag args are valid

http/swagger.yml

@@ -8504,6 +8504,11 @@ components:
                             $ref: "#/components/schemas/TemplateKind"
                           metaName:
                             type: string
+                    links:
+                      type: object
+                      properties:
+                        self:
+                          type: string
               urls:
                 type: array
                 items:

pkger/http_remote_service.go

@@ -330,14 +330,7 @@ func convertRespStackResources(resources []RespStackResource) ([]StackResource,
 			Kind:       r.Kind,
 		}
 		for _, a := range r.Associations {
-			sra := StackResourceAssociation{
-				Kind:     a.Kind,
-				MetaName: a.MetaName,
-			}
-			if sra.MetaName == "" && a.PkgName != nil {
-				sra.MetaName = *a.PkgName
-			}
-			sr.Associations = append(sr.Associations, sra)
+			sr.Associations = append(sr.Associations, StackResourceAssociation(a))
 		}
 
 		resID, err := influxdb.IDFromString(r.ID)
@@ -346,9 +339,6 @@ func convertRespStackResources(resources []RespStackResource) ([]StackResource,
 		}
 		sr.ID = *resID
 
-		if sr.MetaName == "" && r.PkgName != nil {
-			sr.MetaName = *r.PkgName
-		}
 		out = append(out, sr)
 	}
 	return out, nil

pkger/http_server_stack.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"net/http"
 	"net/url"
+	"path"
 	"time"
 
 	"github.com/go-chi/chi"
@@ -85,19 +86,17 @@ type (
 		Kind         Kind                     `json:"kind"`
 		MetaName     string                   `json:"templateMetaName"`
 		Associations []RespStackResourceAssoc `json:"associations"`
-
-		// PkgName is deprecated moving forward, will support until it is
-		// ripped out.
-		PkgName *string `json:"pkgName,omitempty"`
+		Links        RespStackResourceLinks   `json:"links"`
 	}
 
 	// RespStackResourceAssoc is the response for a stack resource's associations.
 	RespStackResourceAssoc struct {
 		Kind     Kind   `json:"kind"`
 		MetaName string `json:"metaName"`
+	}
 
-		//PkgName is to be deprecated moving forward
-		PkgName *string `json:"pkgName,omitempty"`
+	RespStackResourceLinks struct {
+		Self string `json:"self"`
 	}
 )
 
@@ -389,16 +388,14 @@ func convertStackEvent(ev StackEvent) RespStackEvent {
 	for _, r := range ev.Resources {
 		asses := make([]RespStackResourceAssoc, 0, len(r.Associations))
 		for _, a := range r.Associations {
-			asses = append(asses, RespStackResourceAssoc{
-				Kind:     a.Kind,
-				MetaName: a.MetaName,
-			})
+			asses = append(asses, RespStackResourceAssoc(a))
 		}
 		resources = append(resources, RespStackResource{
 			APIVersion:   r.APIVersion,
 			ID:           r.ID.String(),
 			Kind:         r.Kind,
 			MetaName:     r.MetaName,
+			Links:        stackResLinks(r),
 			Associations: asses,
 		})
 	}
@@ -414,6 +411,36 @@ func convertStackEvent(ev StackEvent) RespStackEvent {
 	}
 }
 
+func stackResLinks(r StackResource) RespStackResourceLinks {
+	var linkResource string
+	switch r.Kind {
+	case KindBucket:
+		linkResource = "buckets"
+	case KindCheck, KindCheckDeadman, KindCheckThreshold:
+		linkResource = "checks"
+	case KindDashboard:
+		linkResource = "dashboards"
+	case KindLabel:
+		linkResource = "labels"
+	case KindNotificationEndpoint,
+		KindNotificationEndpointHTTP,
+		KindNotificationEndpointPagerDuty,
+		KindNotificationEndpointSlack:
+		linkResource = "notificationEndpoints"
+	case KindNotificationRule:
+		linkResource = "notificationRules"
+	case KindTask:
+		linkResource = "tasks"
+	case KindTelegraf:
+		linkResource = "telegrafs"
+	case KindVariable:
+		linkResource = "variables"
+	}
+	return RespStackResourceLinks{
+		Self: path.Join("/api/v2", linkResource, r.ID.String()),
+	}
+}
+
 func stackIDFromReq(r *http.Request) (influxdb.ID, error) {
 	stackID, err := influxdb.IDFromString(chi.URLParam(r, "stack_id"))
 	if err != nil {