Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): update giraffe to fix spacing between ticks #17692

Merged
merged 2 commits into from
Apr 9, 2020
Merged

fix(ui): update giraffe to fix spacing between ticks #17692

merged 2 commits into from
Apr 9, 2020

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Apr 9, 2020

Closes #17585

Update giraffe to:

Separate the generation of vertical and horizontal ticks to allow different spacing. For each direction, ticks can be time ticks or value ticks.

x: time, y: value
Screen Shot 2020-04-08 at 4 37 32 PM

y: time, x: value
Screen Shot 2020-04-08 at 4 38 00 PM

@TCL735 TCL735 requested review from a team and asalem1 and removed request for a team April 9, 2020 00:07
@TCL735 TCL735 merged commit e170b5d into master Apr 9, 2020
@TCL735 TCL735 deleted the fix_17585_upgrade_giraffe branch April 9, 2020 00:46
@TCL735 TCL735 mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@asalem1 asalem1 Awaiting requested review from asalem1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scatter Plot X-axis is unreadable
2 participants
@TCL735 @hoorayimhelping