perf: TableGraphTable: tweak rendering internal state #17521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdelambre
approved these changes
Apr 1, 2020
hoorayimhelping
force-pushed
the
bs_table_scrolling
branch
3 times, most recently
from
6f203e3 to
7f4afbc
Compare
fields that are often re-updated but rarely change value were moved out of react state and into internal component state. changing these values won't force re-renders.
hoorayimhelping
force-pushed
the
bs_table_scrolling
branch
from
7f4afbc to
e21e44c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering graphs in table view is kind of painful. Scrolling is a bit rough. This is a quick, small, low hanging fruit.
Moved two fields out of React state into internal component state
this.state.foo➡️this.fooso that changing them doesn't force re-renders needlessly.Here is a comparison of the flamegraphs using React's profiling tools. These flame graphs represent scrolling the table at a normal speed. The graphs take place during the same slice of time - the start of the table scroll.
master
branch
Not a yuge win, but definitely less bursty on the flame graph. A couple of these types of small, easy wins will cumulatively make this feel much better.
I can share the performance
.jsonfiles if you'd like to take a look yourself.