fix(ui): fixed threshold check bug that wouldn't allow threshold checks to be created where fields had spaces in them #17391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalem1
requested review from
a team and
zoesteinkamp
and removed request for
a team
asalem1
changed the title
|
does typing in a flux query with |
asalem1
force-pushed
the
fix/threshold-check-bug
branch
from
bb3f8e5 to
1988012
Compare
Yup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17129
Problem
API could not handle spaces in field names
Solution
Updated the
ast.MemberExpressionProperty to be a string rather thanast.Identifierso that we forced properties to bracket notation instead of dot notation (which was the cause of the error)