Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): display graphic in time machine top when in empty state #17271

Merged
merged 2 commits into from
Mar 13, 2020
Merged

feat(ui): display graphic in time machine top when in empty state #17271

merged 2 commits into from
Mar 13, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Mar 13, 2020 •
edited
Loading

Closes #17150

Screen Shot 2020-03-13 at 3 06 53 PM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested review from a team and asalem1 and removed request for a team March 13, 2020 22:17
drdelambre
drdelambre reviewed Mar 13, 2020
View reviewed changes
ui/src/timeMachine/components/TimeMachine.scss
background-position: center center;
background-size: contain;
background-repeat: no-repeat;
background-image: url('../../assets/images/radial-power-level.svg');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this to absolute paths with '~src/assets/images/radial-power-level.svg'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It throws an error when I try that

@alexpaxton alexpaxton merged commit 57de029 into master Mar 13, 2020
@alexpaxton alexpaxton deleted the feat/de-empty-graphic branch March 13, 2020 22:41
@alexpaxton alexpaxton mentioned this pull request Mar 16, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdelambre drdelambre drdelambre left review comments

@asalem1 asalem1 asalem1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Graphic to Dashboard empty state
3 participants
@alexpaxton @drdelambre @asalem1