fix: stop looping so hard #16453
Merged
fix: stop looping so hard #16453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121watts
approved these changes
Jan 8, 2020
added 2 commits
January 8, 2020 13:04
ghost
requested review from
glinton and
zoesteinkamp
and removed request for
a team
alexpaxton
pushed a commit
that referenced
this pull request
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16452
Closes #16454
just adds a check to see if we've already selected that bad boy before we try and select it again, and again, and again, and.... [ MAXIMUM CALL STACK EXCEEDED ]