Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd/influx): show see help, instead of usage #16374

Merged
merged 1 commit into from
Dec 31, 2019
Merged

fix(cmd/influx): show see help, instead of usage #16374

merged 1 commit into from
Dec 31, 2019

Conversation

kelwang
Copy link
Contributor

@kelwang kelwang commented Dec 31, 2019 •
edited
Loading

Closes #13768

so the plan for this one:

  • Do not show the "help" message for any errors for any command
  • Add a message to the end of each error saying See 'influx <cmd> -h' for help

Manually tested

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@kelwang kelwang requested a review from a team December 31, 2019 19:52
jsteenb2
jsteenb2 reviewed Dec 31, 2019
View reviewed changes
cmd/influx/main.go
}

if parent.TraverseChildren {
cmd, _, err = parent.Traverse(args)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since they're being ignored, can you just do cmd, _, _ = for these spots?

jsteenb2
jsteenb2 reviewed Dec 31, 2019
View reviewed changes
go.mod Show resolved Hide resolved
jsteenb2
jsteenb2 approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, question about needing to import the newer versions of things is a potential blocker though

@kelwang
Copy link
Contributor Author

kelwang commented Dec 31, 2019

lgtm, question about needing to import the newer versions of things is a potential blocker though

Not a blocker, but they have a lot of cleanup, should only help

@kelwang kelwang merged commit 7eb04a0 into master Dec 31, 2019
@kelwang kelwang deleted the cli_usage_fix branch December 31, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteenb2 jsteenb2 jsteenb2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

influx command should not display usage when the error is returned from a query
2 participants
@kelwang @jsteenb2